search

eclipse-viatra / org.eclipse.viatra

Main components of the VIATRA framework
https://eclipse.dev/viatra
Eclipse Public License 2.0
0 stars 1 forks source link

Loosen validation for aggregation chains #136

Closed eclipse-viatra-bot closed 2 months ago

eclipse-viatra-bot commented 3 months ago

| --- | --- | | Bugzilla Link | 578433 | | Status | NEW | | Importance | P3 normal | | Reported | Jan 28, 2022 09:24 EDT | | Modified | Jan 28, 2022 12:44 EDT | | Version | 2.6.0 | | Reporter | Zoltan Ujhelyi |

Description

As of VIATRA 2.6, aggregating over feature chains always throws a warning because given endpoints the path are not unique in general which would cause very surprising results.

On the other hand, if the endpoints of the path uniquely identify the path itself, this warning is unnecessary. The most common (and statically verifiable) case is when the edges traverse through the containment hierarchy. We should update the validator not to emit the "Aggregating feature chains might provide unexpected results." message when traversing through the containment hierarchy.

eclipse-viatra-bot commented 3 months ago

By Gabor Bergmann on Jan 28, 2022 12:44

I think EReferences with multiplicity to-one and one-to (i.e. eOpposite is to-one) should all be taken into account, in addition to containments.