search

eclipse-viatra / org.eclipse.viatra

Main components of the VIATRA framework
https://eclipse.dev/viatra
Eclipse Public License 2.0
0 stars 1 forks source link

Code generation silently fails if the project name contains spaces #154

Closed KocsisV closed 2 months ago

KocsisV commented 3 months ago

In eclipse if the project name contains spaces then the code generation from the VQL files silently fails, nothing is generated. No entry gets added to the problems, nor the error log. Renaming the project to something without spaces solves the issue.

ujhelyiz commented 3 months ago

Question for clarification: by project name you mean the folder name the project is in, the UI-only project name or both (by default, they are the same, but they don't have to be).

KocsisV commented 3 months ago

The UI only project name, which might not be the same as the folder name as you said.

bergmanngabor commented 2 months ago

https://github.com/eclipse-viatra/org.eclipse.viatra/blob/cb120e7d84fe7352686a312c4f7a39f51b9eb930/query/plugins/org.eclipse.viatra.query.patternlanguage.emf.ui/src/org/eclipse/viatra/query/patternlanguage/emf/ui/builder/EMFPatternLanguageBuilderParticipant.java#L124

I think this is it. We compare the project name to the delta URI, without encoding the project name to be URI-compliant. The URI will have %20 instead of regular space characters.