search

eclipse-viatra / org.eclipse.viatra

Main components of the VIATRA framework
https://eclipse.dev/viatra
Eclipse Public License 2.0
1 stars 1 forks source link

#143 Suppressable validations (element in expression, neg recursion) #160

Closed bergmanngabor closed 1 month ago

bergmanngabor commented 5 months ago

Fixes #143

ujhelyiz commented 5 months ago

How does this relate to #143 ?

bergmanngabor commented 5 months ago

How does this relate to #143 ?

Introduces two new VQL annotations for suppressing pattern validation errors - one for each of the two concrete cases discussed in the issue #143. It does not introduce a generic mechanism for all diagnostics.

ujhelyiz commented 5 months ago

Sorry, I meant #148 - I really need to get used to PRs and tickets having the exact same number format. :D

bergmanngabor commented 5 months ago

Sorry, I meant #148 - I really need to get used to PRs and tickets having the exact same number format. :D

In that case, no relation at all. I have completely forgotten about #148.

The current attempt is more mature, so I am in favor of abandoning #148 - but before that, we can discuss which version of the wording of annotation descriptions (and annotation names) we like better, so that we can have the best possible version merged.

bergmanngabor commented 5 months ago

@ujhelyiz I have reworded annotation names and descriptions, partially lifting some text from the older PR https://github.com/eclipse-viatra/org.eclipse.viatra/pull/148 that is now ready to be abandoned.

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud