Local Search handles types incorrectly

[eclipse-viatra-bot]

| --- | --- | | Bugzilla Link | 507032 | | Status | NEW | | Importance | P3 normal | | Reported | Nov 04, 2016 08:03 EDT | | Modified | Nov 23, 2020 08:30 EDT | | Version | 1.5.0 | | See also | Gerrit change https://git.eclipse.org/r/84482, Git commit 75bd8b12 | | Reporter | Gabor Bergmann |

Description

The Local Search backend seems to handle types incorrectly, as evidenced by the Types Test uploaded to Gerrit at https://git.eclipse.org/r/#/c/84461/

1. The nonceEString pattern below should have no matches if the nonce truly does not occur in the model:

   pattern nonceAny(str) = {\ str == "tKmJp4VZFU";\ }\ pattern nonceEString(str : EString) = {\ find nonceAny(str);\ }

2. LS often fails to find any matches for the following pattern (though from JUnit it appears to work):

   pattern identifierAny(obj, id) {\ Identifiable.identifier(obj, id);\ }

[eclipse-viatra-bot]

Nov 04, 2016 11:46

New Gerrit change created: https://git.eclipse.org/r/84482

[eclipse-viatra-bot]

Nov 04, 2016 15:30

Gerrit change https://git.eclipse.org/r/84482 was merged to [master].\ Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=75bd8b12c00c54755865b2639ac1da5dd229afc3

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Nov 30, 2016 14:32

I have taken a quick look at the issue here, and the bad news is that while there is a command in local search for EDataType checks, it does only an instanceof check here.

Possible solutions:

• The EDataType instanceof could rely on Base to calculate whether there is any model attribute with the corresponding value.
• Or we could traverse the model manually.

Balázs, what do you think about this?

[eclipse-viatra-bot]

By Balazs Grill on Dec 02, 2016 03:01

We talked with Zoltán about this issue, and decided that this should be implemented for 1.6. To check whether a given value exists in the model, the InstanceOfDataTypeCheck should rely on the base index, and an alternative implementation should be provided which traverses the model if the base index is not available.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Mar 16, 2017 09:52

M2 has passed, postponing all issues.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on May 02, 2017 03:43

Postponed to 1.7

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Oct 04, 2017 05:04

Postponing.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Feb 08, 2018 07:21

Postponing to a future release.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on May 27, 2019 07:49

Bugzilla cleanup.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Nov 20, 2019 05:51

Postponing issues to the next release.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on May 18, 2020 13:04

Postponing issues that will not be solved for version 2.5.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Nov 23, 2020 08:30

Mass postponing of issues to the 2.6 timeframe.