Revisit local search adapters again

[eclipse-viatra-bot]

| --- | --- | | Bugzilla Link | 535101 | | Status | NEW | | Importance | P3 enhancement | | Reported | May 25, 2018 04:11 EDT | | Modified | Nov 23, 2020 08:30 EDT | | Version | 2.0.0 | | See also | 535102, Gerrit change https://git.eclipse.org/r/123313, Git commit d731df70 | | Reporter | Zoltan Ujhelyi |

Description

The updated local search adapter interface in version 2.0 went in the good direction, but we (with Balázs Grill) have noticed two different issues with the current iteration:

• Although the adapter mostly provide a static view of the execution, in two ways the internal, dynamic parts are still leaking:\ (1) Firstly, the patternMatchingStarted and noMoreMatchesAvailable the LocalSearchMatcher instance is returned. In this case, the required information should be a MatcherReference (or a PQuery and adornment information).\ (2) In most methods, the MatchingFrame is returned that is modifiable, although it really should be. It would be better to provide an ITuple view of the frame, that provides no methods to modify the frame contents. This does not require instantiating any new objects, etc. but would result in a simpler interface.
• Another issue is one concrete dynamic information that is required for global adapters, especially if for any reason multiple matcher calls can execute in parallel: some execution identifier should be included in adapter calls. This latter part will also require changes in internal matcher APIs as well.

[eclipse-viatra-bot]

May 25, 2018 04:37

New Gerrit change created: https://git.eclipse.org/r/123313

[eclipse-viatra-bot]

May 25, 2018 08:29

Gerrit change https://git.eclipse.org/r/123313 was merged to [master].\ Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=d731df70ce45a98b2501801e866510437c0914b0

[eclipse-viatra-bot]

By Zoltan Ujhelyi on May 27, 2019 07:49

Bugzilla cleanup.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Nov 20, 2019 05:51

Postponing issues to the next release.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on May 18, 2020 13:04

Postponing issues that will not be solved for version 2.5.

[eclipse-viatra-bot]

By Zoltan Ujhelyi on Nov 23, 2020 08:30

Mass postponing of issues to the 2.6 timeframe.