eclipse-viatra / org.eclipse.viatra

Main components of the VIATRA framework
https://eclipse.dev/viatra
Eclipse Public License 2.0
1 stars 2 forks source link

Focus issues with the embedded Xtext editor for VGQL files #98

Open eclipse-viatra-bot opened 8 months ago

eclipse-viatra-bot commented 8 months ago

| --- | --- | | Bugzilla Link | 541512 | | Status | NEW | | Importance | P3 normal | | Reported | Nov 23, 2018 10:43 EDT | | Modified | Nov 23, 2018 15:22 EDT | | Version | 2.1.0 | | See also | Gerrit change https://git.eclipse.org/r/132991, Git commit e7b76bbe | | Reporter | Zoltan Ujhelyi |

Description

This issue is a followup from bug 539176.

When pressing Ctrl+A (or Cmd+A on macOS), the embedded Xtext editor does not select the edited text but select some elements from the diagram being edited (e.g. all elements inside the same pattern as the original elemet). When opening the popup menu and selecting Select All from there, it works as expected.

Clipboard operations, e.g. Ctrl+C behave similarly.

In a debug session I have identified that the popup menu items are directly registered as Actions, while Ctrl+A is executed on a completely different path, where command handlers are being looked up.

By loading the editor as a selection provider for the current workbench site I have managed to avoid changing the selection on the diagram, but I have found no way to forward the Select all command to the embedded Xtext editor.

eclipse-viatra-bot commented 8 months ago

Nov 23, 2018 10:53

New Gerrit change created: https://git.eclipse.org/r/132991

eclipse-viatra-bot commented 8 months ago

Nov 23, 2018 15:22

Gerrit change https://git.eclipse.org/r/132991 was merged to [master].\ Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=e7b76bbe7842737ef948370b0847b65a7370bfe5