eclipse-volttron / volttron-core

Other
7 stars 10 forks source link

publish new volttron wheel to pypi #19

Open craig8 opened 2 years ago

craig8 commented 2 years ago

Start publishing dev versions of volttron wheel to pypi when a pr is merged to develop.

Publish new version "released" of wheel to pypi when a merge to releases is done.

@shwethanidd @bonicim @jhaack @schandrika When should the incrementation of the version number be done do you think? In the github actions?

craig8 commented 2 years ago

https://www.python.org/dev/peps/pep-0440/

craig8 commented 2 years ago

I believe we should use this workflow https://aboutbits.it/blog/2021-03-11-using-github-actions-to-perfom-npm-version-increment.

as a pattern perhaps...

Two things we would change are:

Thoughts?

craig8 commented 2 years ago

So our incrementation is going to be based upon releases of dev versions and the workflow will be as follows.

  1. Merge/commit to develop.
  2. Check the commit message for [RELEASE] if not found then increase version number of patch with dev and commit it to the repository.
  3. Deploy the pyproject if [RELEASE] is found in the head message.
craig8 commented 2 years ago

After using this in a test repo https://github.com/craig8/test-release-actions/tree/develop

I don't like the "RELEASE" thingy being pushed back to the repo. Everyone would have to rebase/merge after each commit. So instead I think we tag a release and push the artifact when a push to develop happens.

Much cleaner.

bonicim commented 2 years ago

I like how we auto-increment the version number instead of manually having to set the version number ourselves. Doing it within Github Actions and using Poetry to increment makes sense.