search

eclipse-volttron / volttron-openadr-ven

Apache License 2.0
5 stars 5 forks source link

creating stepped events #16

Closed bbartling closed 2 years ago

bbartling commented 2 years ago

I am experimenting with creating an event "curve" like shown on the IPKeys side:

image

I think something maybe getting goofed up on the openLeadr or possibly VOLTTRON code as the "durations" configured in IPKeys appear NOT to be getting pushed down to the VEN as shown below the durations in the volttron.log are all 0.

image

Payload signals seem to come thru OK but what about durations???? How can this be troubleshot???

bonicim commented 2 years ago

Just tried reproducing this issue on my end and got the same issue. I suspect it has something to do with how the Volttron OpenADR agent is parsing the 'event'. Will attempt to fix and post an update with screen shots.

bonicim commented 2 years ago

I fixed the issue. The agent was not deserializing the Event object correctly.

See this change on the line of code in #17: https://github.com/VOLTTRON/volttron-openadr-ven/blob/bf6c04f681009d4ac91e4f970489a0960d3f9949/volttron_openadr_ven/agent.py#L305-L313

Screenshot of logs. On the left is the logs for the agent. On the right is the logs of the volttron platform.

Screen Shot 2021-12-08 at 3 39 36 PM

bbartling commented 2 years ago

Nice work Mark!. Is that in openLeadr code? The link isnt working from my phone.

On Wed, Dec 8, 2021, 5:45 PM Mark Bonicillo @.***> wrote:

I fixed the issue. The agent was not deserializing the Event object correctly.

See this change on the line of code in #17 https://github.com/VOLTTRON/volttron-openadr-ven/pull/17: https://github.com/VOLTTRON/volttron-openadr-ven/blob/bf6c04f681009d4ac91e4f970489a0960d3f9949/volttron_openadr_ven/agent.py#L305-L313

Screenshot of logs. On the left is the logs for the agent. On the right is the logs of the volttron platform.

[image: Screen Shot 2021-12-08 at 3 39 36 PM] https://user-images.githubusercontent.com/6901848/145308566-982faff1-be33-44f2-986f-ed470b6068e6.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/VOLTTRON/volttron-openadr-ven/issues/16#issuecomment-989317880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHC4BHL5AIRKAADM4USJIVDUP7UZJANCNFSM5IOE5FYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

bonicim commented 2 years ago

Nice work Mark!. Is that in openLeadr code? The link isnt working from my phone. … On Wed, Dec 8, 2021, 5:45 PM Mark Bonicillo @.***> wrote: I fixed the issue. The agent was not deserializing the Event object correctly. See this change on the line of code in #17 <#17>: https://github.com/VOLTTRON/volttron-openadr-ven/blob/bf6c04f681009d4ac91e4f970489a0960d3f9949/volttron_openadr_ven/agent.py#L305-L313 Screenshot of logs. On the left is the logs for the agent. On the right is the logs of the volttron platform. [image: Screen Shot 2021-12-08 at 3 39 36 PM] https://user-images.githubusercontent.com/6901848/145308566-982faff1-be33-44f2-986f-ed470b6068e6.png — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHC4BHL5AIRKAADM4USJIVDUP7UZJANCNFSM5IOE5FYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

It's in the agent code. See https://github.com/bonicim/volttron-openadr-ven/blob/update/patches/volttron_openadr_ven/agent.py#L307