Implemented client side send operation

eclipse-wakaama / wakaama

Eclipse Wakaama is a C implementation of the Open Mobile Alliance's LightWeight M2M protocol (LWM2M).

BSD 3-Clause "New" or "Revised" License

498 stars 374 forks source link

Implemented client side send operation #717

Closed parmi93 closed 1 year ago

parmi93 commented 1 year ago

Implemented send operation for client side, send operation was introduced with the LwM2M 1.1 standard. This PR is based on work from @sbertin-telular, specifically on send branch: https://github.com/sbertin-telular/wakaama/tree/send

In this PR a bug that caused a memory leak has been fixed: https://github.com/sbertin-telular/wakaama/pull/1

LukasWoodtli commented 1 year ago

The code looks good to me now. Thanks for your effort!

Two improvements you could do for your commit:

Squash your commits into one commit, as it is one change that should be merged into the repo
Use imperative mood for the commit messages subject line

parmi93 commented 1 year ago

Commits squashed and commit message subject line changed.

parmi93 commented 1 year ago

Code formatted with clang-format.

parmi93 commented 1 year ago

Code formatted with git clang-format-14

mlasch commented 1 year ago

Sorry for the delay. I did a quick smoke test and it works.