prv_getParameters / fix query len check

eclipse-wakaama / wakaama

Eclipse Wakaama is a C implementation of the Open Mobile Alliance's LightWeight M2M protocol (LWM2M).

BSD 3-Clause "New" or "Revised" License

498 stars 374 forks source link

Closed semhoun closed 10 months ago

semhoun commented 10 months ago

When the query is QUERY_QUEUE_MODE test of the len is compared with QUERY_BINDING_LEN and not QUERY_QUEUE_MODE_LEN. It's like an erronous copy/paste.

rettichschnidi commented 10 months ago

Thanks for your PR, nice catch! Before we can integrate, please sign the ECA.

semhoun commented 10 months ago

I signed the ECA.

rettichschnidi commented 10 months ago

CI requires a commit to have a body. If you ~~annotate~~ amend the commit with what you described in the PR, CI will pass.

rettichschnidi commented 10 months ago

Sorry, amend is what I meant (git commit --amend). You can read up on how to do this here.

Since you allowed maintainer edits, I just massaged the commit a bit, so it (hopefully) passes the CI. Will merge once it does.

Thanks a lot!

semhoun commented 10 months ago

Thanks, i will know for the future.