search

eclipse-wildwebdeveloper / wildwebdeveloper

Simple and productive Web Development Tools in the Eclipse IDE
https://projects.eclipse.org/projects/tools.wildwebdeveloper
Eclipse Public License 2.0
190 stars 71 forks source link

Selection highlighting not working #104

Closed PyvesB closed 3 years ago

PyvesB commented 5 years ago

Hello,

I'm having trouble with the highlight feature. When I select a variable, I would expect all occurrences to be highlighted, however, this is not the case. Note that I have the Toggle Highlight option enabled. See screenshot below: screenshot 128

Thanks in advance for your help!

Cheers,

Pyves

mickaelistria commented 5 years ago

The connection and request with the Language Server seem correct, but the LS returns a "wrong" result. It's most likely an issue to report to https://github.com/theia-ide/typescript-language-server . Would you like to report it?

PyvesB commented 5 years ago

Thank you for your response. I've submitted an issue here. I'm not too familiar with that project or how language servers work in general, but hopefully it makes sense.

PyvesB commented 5 years ago

Update on this: I sent a PR to the Typescript Language server, https://github.com/theia-ide/typescript-language-server/pull/125.

PyvesB commented 3 years ago

26c8c68faadf1afda0d8d7632faa826e008f0898 finally pulled in the aforementioned fix. I can confirm that the problem is now resolved on Windows, closing. :)