search

eclipse-wildwebdeveloper / wildwebdeveloper

Simple and productive Web Development Tools in the Eclipse IDE
https://projects.eclipse.org/projects/tools.wildwebdeveloper
Eclipse Public License 2.0
189 stars 70 forks source link

[XML] Investigate not using fatjar and using OSGi bundles as depedencies #122

Closed mickaelistria closed 4 years ago

mickaelistria commented 5 years ago

Currently, XML-LS is included as a fatjar containing all the dependencies. Most of the dependencies seem to be available in the Wild Web Developer target platform. We should consider using the "small" jar without the dependencies and get the dependencies provided through OSGi. That may require having a specific bundle for XML-LS which would declare its requirements, and that probably relates with having XML-LS including OSGi metadata.

mickaelistria commented 5 years ago

Related to https://github.com/angelozerr/lsp4xml/issues/288

mickaelistria commented 5 years ago

LSP4XML now published p2 repo at https://lsp4xml.jfrog.io/lsp4xml/generic-local/p2/lsp4xml/0.4.0-SNAPSHOT/ After the upcoming release, we should initiate this work and adopt it -unless issues- when LSP4XML 0.4.0 releases.

mickaelistria commented 4 years ago

We'll work on it when XML-LS is an Eclipse project and publishes signed OSGi bundles.

mickaelistria commented 4 years ago

We've abandoned this idea at the moment. Delivering an alternative packaging of the language server adds a lot of difficulty over just reusing the fatjar, we'll stick to it for now.