search

eclipse-wildwebdeveloper / wildwebdeveloper

Simple and productive Web Development Tools in the Eclipse IDE
https://projects.eclipse.org/projects/tools.wildwebdeveloper
Eclipse Public License 2.0
189 stars 70 forks source link

update lemminx to 0.28.0 #1628

Closed martinlippert closed 2 months ago

martinlippert commented 2 months ago

The lemminx language server in version 0.27.0 throws a nasty error in some cases (see https://github.com/eclipse/lemminx/issues/1653) that has been fixed on 0.28.0, so updating to that version would be awesome.

mickaelistria commented 2 months ago

The eslint failures are not related, let's merge.

martinlippert commented 2 months ago

Awesome, thanks @mickaelistria. Any idea when a new release build might be around that includes this upgrade? Any plans?

mickaelistria commented 2 months ago

I think we can release as soon as the 4 failing ESLint tests are resolved. However, I'm not aware of anyone looking at them nor planning to look at them on short term. If you can spend a bit of time investigating those, that would be helpful.

martinlippert commented 2 months ago

I think we can release as soon as the 4 failing ESLint tests are resolved. However, I'm not aware of anyone looking at them nor planning to look at them on short term. If you can spend a bit of time investigating those, that would be helpful.

I will most likely not be able to spend time on this myself at the moment (vacation coming up), but I will ask someone from the team to support here.

mickaelistria commented 2 months ago

We have reverted the change that was causing the 4 failures, so no further work is needed here. The current issue that prevents from a release is some IP approval for some NPM dependencies (I don't remember which ones and the build log isn't verbose enough to figure it out)

martinlippert commented 2 months ago

We have reverted the change that was causing the 4 failures, so no further work is needed here. The current issue that prevents from a release is some IP approval for some NPM dependencies (I don't remember which ones and the build log isn't verbose enough to figure it out)

Alright, thanks for that update. Looking forward to the IP approval and a new release build sometime afterwards then... :-) Many many thanks!!!