payload_data column family exists and no data_info column Family exists,
currently we are generating a timestampZenohId=1 upon retrieval of the data stored and sending the timestamp to zenoh.
However we are not adding the metadata to the database.
With the timestamp rework happening in https://github.com/eclipse-zenoh/zenoh/pull/1188, we no longer have access to the new_reception_timestamp function
This will effect replication logic.
After discussion with @JEnoch, proposed solution to fix this is at start up either:
Refuse to start Plugin if no metadata is detected in database.
metadata includes, timestamp, deleted flag, and encoding.
Start plugin, and for payloads that do not have meta-data, generate metadata
its possible to generate metadata for timestamp. but not for deleted flag or encoding.
I'm not sure this option is possible if we do not know the original encoding of the data.
To reproduce
Start instance of plugin with RocksDB,
with existing Rocksdb database,
and existing payload data but no data_info column family.
Describe the bug
payload_datacolumn family exists and nodata_infocolumn Family exists, currently we are generating atimestampZenohId=1upon retrieval of the data stored and sending the timestamp to zenoh. However we are not adding the metadata to the database. With the timestamp rework happening in https://github.com/eclipse-zenoh/zenoh/pull/1188, we no longer have access to thenew_reception_timestampfunction This will effect replication logic.After discussion with @JEnoch, proposed solution to fix this is at start up either:
Refuse to start Plugin if no metadata is detected in database. metadata includes,
timestamp,deletedflag, andencoding.Start plugin, and for payloads that do not have meta-data, generate metadata its possible to generate metadata for timestamp. but not for deleted flag or encoding. I'm not sure this option is possible if we do not know the original encoding of the data.
To reproduce
Start instance of plugin with RocksDB, with existing Rocksdb database, and existing payload data but no
data_infocolumn family.System info
zenoh-backend-rocksdbgit hash679be9788309c611ccd29cdff586d4a5a2f17e64