search

eclipse-zenoh / zenoh-c

C API for Zenoh
http://zenoh.io
Other
74 stars 54 forks source link

add build configuration without shared memory #406

Closed milyin closed 3 months ago

milyin commented 4 months ago

Describe the release item

Some customers needs zenoh-c wihout shared memory enabled. There should be cmake option for it and this configuration should be tested in CI

yellowhatter commented 3 months ago

A few comments on this....

I did an investigation that highlighted the following problems:

  1. Some pieces of our codegeneration process do not intend to support features. Practically it means that zenoh-c cannot conditionally exclude some API bindings. To be fixed
  2. Turning off shared-memory feature in underlying Zenoh changes some type's sizes and break some hacky assumptions made for ZBytes in zenoh-c. To be refactored.

Currently we had a discussion with API crew on important details and I'm in progress with this issue

milyin commented 3 months ago

done, zenoh-c builds correctly with different features in Cargo.toml.in