search

eclipse-zenoh / zenoh-c

C API for Zenoh
http://zenoh.io
Other
74 stars 55 forks source link

remove constructor of `z_entty_global_id_t` and it's fields access #486

Closed milyin closed 2 months ago

milyin commented 3 months ago

Describe the release item

In the existing Rust API the EntityGlobalId is a wrapper fo EntityGlobalIdProto. All details of EntityGlobalIdProto is hidden now. So functions z_entity_global_id_new, z_entity_global_id_zid, z_entity_global_id_eid should also be removed from C API

milyin commented 3 months ago

@Mallets please confirm, that now EntityGlobalId is blind and user should not neither be able to create it manually nor have access to (SessionId, EntityId) fields @wyfo, thank you for noticing this issue in zenoh-c API

Mallets commented 3 months ago

EntityGlobalId is internal and users should only have read access to it. In any case, EntityGlobalId should only be present in SourcInfo which is unstable if I'm not mistaken.

milyin commented 3 months ago

Should be fixed in https://github.com/eclipse-zenoh/zenoh-c/pull/485

milyin commented 2 months ago

Rust's EntityGlobalId provides RO access to zid and eid fields. Constructor is removed. So C API is ok,