search

eclipse-zenoh / zenoh

zenoh unifies data in motion, data in-use, data at rest and computations. It carefully blends traditional pub/sub with geo-distributed storages, queries and computations, while retaining a level of time and space efficiency that is well beyond any of the mainstream stacks.
https://zenoh.io
Other
1.36k stars 142 forks source link

[dev/1.0.0] Rename `publisher`/`subscriber` modules into `publication`/`subscription` and merge `queryable` into `query` #1181

Closed wyfo closed 2 days ago

wyfo commented 1 week ago

Describe the feature

zenoh::publisher was previously named zenoh::publication, but was renamed to be aligned with subscriber (query module is still not aligned btw). However, maybe we should reverse this renaming, and also rename subscriber module into subscription.

There would be an issue for queryable module, as it would have to be named query, but there is already a module named query. IMO, both should be merged, because queryable is also related to query; now, we have a strange situation where Query type lies in queryable module and not query.

@Mallets @kydos @milyin

kydos commented 1 week ago

@wyfo I may go one step further, and use the short form pub and sub and query as the latter is short enough.

wyfo commented 1 week ago

Do you mean zenoh::r#pub? And we are back to use keywords as module name 😛 More seriously, we could also keep the name and provide a renamed reexport, like pub use subscriber as sub.

Mallets commented 1 week ago

Another option could be to unify pub and sub in pubsub. Similarly for query and queryable unified into query.

wyfo commented 1 week ago

I like this idea!

Mallets commented 1 week ago

@wyfo Could you open a PR that address this issue plus https://github.com/eclipse-zenoh/zenoh/issues/1147 and https://github.com/eclipse-zenoh/zenoh/pull/1160? I think we should converge on this aspect pretty soon before the final 1.0.0 release.

wyfo commented 1 week ago

1147 should be closed, decision having already been taken with #1007.

For #1160, @evshary finally agree with the reexport, and for my part, I like so much zenoh::pubsub that I don't think having zenoh::Publisher is important anymore. So it may also be closed.

I will open a PR.

Mallets commented 2 days ago

Closed by https://github.com/eclipse-zenoh/zenoh/pull/1193