Some configuration errors are silently ignored

eclipse-zenoh / zenoh

zenoh unifies data in motion, data in-use, data at rest and computations. It carefully blends traditional pub/sub with geo-distributed storages, queries and computations, while retaining a level of time and space efficiency that is well beyond any of the mainstream stacks.

https://zenoh.io

Other

1.37k stars 141 forks source link

Some configuration errors are silently ignored #1225

Closed fuzzypixelz closed 4 days ago

fuzzypixelz commented 3 weeks ago

Describe the bug

If make a an error in a configuration field such as scouting/multicast/connect Zenoh will act as if the field was null. The log shows zero warnings and zero errors.

To reproduce

Start a Zenoh router with scouting/multicast/connect/router set to 42

System info

ref: 45cfe784189818dd9dd3d5ce7fc27436ecc0d211

fuzzypixelz commented 4 days ago

Fixed in https://github.com/eclipse-zenoh/zenoh/pull/1224 by removing the #[serde(deserialize_with = "treat_error_as_none")] attributes. If I understand correctly this was the only instance where this issue occurred. We can reopen this otherwise.