eclipse-zenoh / zenoh

zenoh unifies data in motion, data in-use, data at rest and computations. It carefully blends traditional pub/sub with geo-distributed storages, queries and computations, while retaining a level of time and space efficiency that is well beyond any of the mainstream stacks.
https://zenoh.io
Other
1.44k stars 151 forks source link

Documentation: Typos and clarifications #1387

Closed awesomebytes closed 3 weeks ago

awesomebytes commented 3 weeks ago

Describe the bug

Hello, given I can't find a repo with the documentation to do a PR directly, I may as well point out minor typos I found when reading the docs.

Zenoh applications in peer mode forward all local applications and router they already discovered to newly scouted applications.

router -> routers

they already discovered -> they have already discovered

dedicate -> dedicated

administer -> administering

get/put -> GET/PUT (to follow the rest of the docs)

put -> PUT

Note that while you may attempt to change any part of the configuration through this mean, not all of its properties are actually watched. For example, while the storage plugin watches for any change in its configuration and will attempt to act on it, the REST plugin will only log a warning that it observed a change, but won’t apply it. Changes to non-plugin parts of the configuration may be registered by the configuration, but not acted upon, such as the mode field of the configuration which is only ever read at startup.

Not really a typo, but I found this explanation pretty confusing. Maybe a list or diagram of "Watched properties and how they are acted upon changes" would help.

Double ":"

Well, it's a TODO, just thought I'd bring it up.

[1] Off-topic: In https://zenoh.io/docs/getting-started/troubleshooting/ it says that: "Error treating timestamp for received Data" may appear if there is a discrepancy in between clocks of 100ms. When teaching ROS to students, specially in environments without access to the internet, just a local network, drifts in the clock were a relatively common issue. By using messages without a timestamp, we could overcome teaching the basics ignoring these kind of problems. Is there a way to ignore timestamps in zenoh? Or tune the discrepancy?

To reproduce

Open the docs, read them.

System info

Windows 11, Firefox, it doesn't really matter.

JEnoch commented 3 weeks ago

Thanks for reviewing this! The web site repo is here: https://github.com/atolab/zenoh-web With all the pages as Markdown files under content/ Do you mind creating a PR in here ?

awesomebytes commented 3 weeks ago

Thanks for pointing to that repo @JEnoch I moved the issue there (https://github.com/atolab/zenoh-web/issues/58) and did a PR with what I could fix (https://github.com/atolab/zenoh-web/pull/57).