search

eclipse-zenoh / zenoh

zenoh unifies data in motion, data in-use, data at rest and computations. It carefully blends traditional pub/sub with geo-distributed storages, queries and computations, while retaining a level of time and space efficiency that is well beyond any of the mainstream stacks.
https://zenoh.io
Other
1.52k stars 161 forks source link

Able to check Tokio Runtime is alive inside is_closed. #1569

Closed evshary closed 3 weeks ago

evshary commented 4 weeks ago

The draft PR to deal with the issue https://github.com/ZettaScaleLabs/rmw_zenoh/issues/26

Here is what we do:

  1. Provide a clear panic log to tell developers not to use Zenoh API inside atexit.
  2. Check Tokio Runtime availability inside is_closed API. This can help developers avoid calling Zenoh API in the wrong place.
github-actions[bot] commented 4 weeks ago

PR missing one of the required labels: {'internal', 'dependencies', 'documentation', 'new feature', 'breaking-change', 'bug', 'enhancement'}

evshary commented 3 weeks ago

It would be better to check it on rmw_zenoh. Let's replace it with https://github.com/ZettaScaleLabs/rmw_zenoh/pull/37