search

eclipse-zenoh / zenoh

zenoh unifies data in motion, data in-use, data at rest and computations. It carefully blends traditional pub/sub with geo-distributed storages, queries and computations, while retaining a level of time and space efficiency that is well beyond any of the mainstream stacks.
https://zenoh.io
Other
1.52k stars 161 forks source link

fix small bug in backoff update #1586

Closed yellowhatter closed 2 weeks ago

yellowhatter commented 2 weeks ago

@Mallets I fixed it by forcing operand evaluation order that makes it impossible to have negative values. Maybe this is the fastest approach (I will run zenoh benchmarks for this)

yellowhatter commented 2 weeks ago

@Mallets A very promising result!!!

This branch: 2024:11:07-18:46:38 throughput aggregated

Main: 2024:11:07-19:56:12 throughput aggregated

I think this is because we don't have additional overflow check when doing (-i32)+i32 arithmetic operation because it cannot overflow.

yellowhatter commented 2 weeks ago

additional slight improvement: 2024:11:08-17:10:06 throughput aggregated