search

eclipse / Xpect

This repository has been rewritten to move to the Eclipse Foundation. Find the old history here: https://github.com/TypeFox/Xpect
http://www.xpect-tests.org/
Eclipse Public License 2.0
30 stars 28 forks source link

Double clicking on XPECT test result does not navigate to XPECT statement #261

Open trancexpress opened 5 years ago

trancexpress commented 5 years ago

With xpect 0.1.0 it was possible to double click on a XPECT entry in the JUnit view. This would then open the DSL test file and select the respective XPECT statement.

With xpect 0.2.0 double clicking on an XPECT entry results in a dialog "Method ... not found. Opening test class". Its still possible to right-click on the entry and choose "Go to XPECT method", however this involves more user interaction.

trancexpress commented 5 years ago

Looks like xpect 0.1.0 uses org.xpect.ui.junit.OpenFileAction, which is "registered" when org.xpect.ui.junit.XpectRunnerUIHandler.contextMenuAboutToShow(ViewPart, ITestElement, IMenuManager) is called. I don't find XpectRunnerUIHandler in the xpect 0.2.0 bundles. I do find OpenFileAction in org.eclipse.xpect.ui.junit. However its only used when calling the "Go to XPECT method" menu entry. It doesn't seem to be associated with the "Go to File" entry, which is called on double click.

trancexpress commented 5 years ago

Caused by: https://github.com/eclipse/Xpect/pull/229/files

trancexpress commented 5 years ago

Created JDT bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=546882

I'm looking into this now.

trancexpress commented 5 years ago

This seems to be the original JDT ticket created by Moritz Eysholdt:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=391023