search

eclipse / Xpect

This repository has been rewritten to move to the Eclipse Foundation. Find the old history here: https://github.com/TypeFox/Xpect
http://www.xpect-tests.org/
Eclipse Public License 2.0
32 stars 28 forks source link

Fix Commons logging build problem #361

Open cdietrich opened 1 week ago

cdietrich commented 1 week ago

Proposal:

add the new bundle to both target platforms and adjust build.properties files

cdietrich commented 1 week ago

cc @mehmet-karaman

mehmet-karaman commented 1 week ago

With new bundle you mean the jdt xtext facade project?

cdietrich commented 1 week ago

No the new bundle name for commons logging Check mwe or xtext repo

mehmet-karaman commented 1 week ago

Ok, i am going to try this.

mehmet-karaman commented 1 week ago

started maven build against the two targets in my workspace.. it built succesfully, so are you sure we have to change this?

cdietrich commented 1 week ago

the one against "latest"?

cdietrich commented 1 week ago

i wonder if there is something cached in your local maven repo that is used

cdietrich commented 1 week ago

still failing @mehmet-karaman does it work on your companys replica of the build?

mehmet-karaman commented 1 week ago

Now it fails also on our replica build.. I've used the full-build.sh file for building.. I didn't checked where we get our dependencies, might be that this repo still had this repository where this old bundle was available.

mehmet-karaman commented 1 week ago

I think I can continue from this.. I will create a PR when its finished.. Thanks..