search

eclipse / aCute

Eclipse aCute - C# edition in Eclipse IDE
https://projects.eclipse.org/projects/tools.acute
Eclipse Public License 2.0
80 stars 33 forks source link

Issue #66: Run `dotnet restore` before starting LS #101

Closed LucasBullen closed 6 years ago

LucasBullen commented 6 years ago

Re-add previously removed workaround for https://github.com/OmniSharp/omnisharp-node-client/issues/265

Signed-off-by: Lucas Bullen lbullen@redhat.com

mickaelistria commented 6 years ago

I'm wondering whether it wouldn't be better to wait for OmniSharp to include the LSP support out of the box rather than stacking workarounds for the deprecated nodejs wrapper. What do you think?

LucasBullen commented 6 years ago

I think it is important to have this workaround in for now, until we have the support, as users are not aware of the required dotnet restore and it would be better to do it on our end instead of enforcing a behaviour that will become unnecessary after the OmniSharp update.

mickaelistria commented 6 years ago

Ok, feel free to push to master then.