search

eclipse / aCute

Eclipse aCute - C# edition in Eclipse IDE
https://projects.eclipse.org/projects/tools.acute
Eclipse Public License 2.0
80 stars 33 forks source link

Acute 20230504 #200

Closed zhugezi5 closed 10 months ago

zhugezi5 commented 1 year ago

Fix for No templates

mickaelistria commented 1 year ago

Can you please review and sign the Eclipse Contributor Agreement before we can consider merging your change? https://accounts.eclipse.org/user/login?destination=legal/eca/validation/171897 While code looks OK, it seems like some tests are failing. Can you reproduce those failures locally?

zhugezi5 commented 1 year ago

I used mvn verify command and meet the failures on my computer.

在 2023-09-04 17:29:58，"Mickael Istria" @.***> 写道：

Can you please review and sign the Eclipse Contributor Agreement before we can consider merging your change? https://accounts.eclipse.org/user/login?destination=legal/eca/validation/171897 While code looks OK, it seems like some tests are failing. Can you reproduce those failures locally?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

Fusik commented 1 year ago

@mickaelistria is it possible to merge this fix with no template issue?

mickaelistria commented 1 year ago

@liao.dc also needs to sign the Eclipse Contributor Agreement before we can merge this code.

zhugezi5 commented 1 year ago

signed the Eclipse Contributor Agreement

Fusik commented 11 months ago

any news? @mickaelistria

mickaelistria commented 11 months ago

See the "eclipsefdn/eca" check. there is still a commit attributed to "liao.dc" but this user didn't sign the Eclipse contributor agreement, so we're not allowed to merge it.

zhugezi5 commented 10 months ago

some commit author info wrong