search

eclipse / aCute

Eclipse aCute - C# edition in Eclipse IDE
https://projects.eclipse.org/projects/tools.acute
Eclipse Public License 2.0
80 stars 33 forks source link

Use Gson #85

Closed angelozerr closed 7 years ago

angelozerr commented 7 years ago

As Eclipse IDE hosts Gson, I suggest you that you use GSon instead of using org.json.JSONObject at https://github.com/eclipse/aCute/blob/master/org.eclipse.acute/src/org/eclipse/acute/ProjectFileAccessor.java#L57 to avoid having a new JSOn dependency.

mickaelistria commented 7 years ago

org.json is also a dependency allowed by Eclipse (it's in Orbit). However, LSP4J uses GSon too, so I agree it would be nice to use the same GSon as LSP4J to minimize the amount of total dependencies.

mickaelistria commented 7 years ago

Fixed with 7d879dd