eclipse / amalgam

Eclipse Public License 1.0
1 stars 4 forks source link

[Activity Explorer] NPE at Disposing Overview page #110

Open eclipse-amalgam-bot opened 3 years ago

eclipse-amalgam-bot commented 3 years ago

disposing method in Overview page try to dispose the menu listener from menu manger without checking if the Manged Form is not null.

Some cases (Integration in kitalpha for example, with Component Sample Example) at the refreshing of the activity explorer throws Null Pointer exception at dispoing of the Overview page.

The actual code do something like:

public void dispose(){ getManagedForm().getForm().getFrom().getMenuManager.removeMenuListener(...) ... }

it is justificated to do something like:

public void dispose(){ if (getManagedForm() != null) { getManagedForm().getForm().getFrom().getMenuManager.removeMenuListener(...); } ... }

🆔 ECLIPSE-489647 👷 faycal.abka 📅 2016-03-15

eclipse-amalgam-bot commented 3 years ago

ci-bot commented on 2016-04-08

Merged to [master]. Commit: http://git.eclipse.org/c/amalgam/org.eclipse.amalgam.git/commit/?id=3f2130d4dd26220984dd63cddf39cda82a195d4c

pierre-charles.david commented on 2020-02-20

Hi. It looks like the commit for this has been merged. Can the ticket be closed?