eclipse-amalgam-bot
commented
3 years ago richard.gronback commented on 2009-05-19
Huh? What's wrong with the product:Product reference in the Build element. It is a reference to an instance of a Product model, which is currently modeled after the PDE's product definition.
thomas.hallgren commented on 2009-05-19
The problem is that we now have several contributions that includes products (all EPP packages, the Platform, etc.) so we need a product element that is below the contribution.
richard.gronback commented on 2009-05-19
The Amalgam build model was designed for building a single product, not the aggregating many products/features/etc. as your assembler is doing. As products are not assembled from other products, adding a Product IU type to the model for inclusion within a contribution doesn't make sense (at least for Amalgam).
Why not copy/alter/maintain this model, or create a new one that contains only what you need for assembling the train elements? I just that this will be the last change request for this model. Also, I'm in the middle of dealing with a DSL Toolkit build issue (suddenly, some Modeling sites are broken), so it would take a while to create this new element and promote it anyway.
richard.gronback commented on 2009-05-19
Just to clarify further, you only need an ID and version field in this Product element, right? If I extract an abstract InstallationUnit superclass for the current Feature and Bundle, move id, version and repo to it and add a new Product subclass, that would do it, right?
thomas.hallgren commented on 2009-05-19
That would do it very nicely and yes, I really do think this will be the last change that we need.
Going forward, I agree, it would be a good thing to copy this model and evolve it to something more tailored for the Galileo Builder. I would appreciate if you could do this last change so that I can postpone that rework until after the Galileo release in June since I would like to make a couple of other changes as well at that point that might not be backward compatible.
thomas.hallgren commented on 2009-05-20
Attachment: amalgam.patch Patch adding the InstallationUnit and Product
This patch adds the InstallationUnit as an abstract super class of the existing Feature and Bundle classes and a new Product class. It also adds 'products' to the Contribution class as 0-* Product.
richard.gronback commented on 2009-05-20
Thanks, but I already made the changes.
thomas.hallgren commented on 2009-05-20
Great. I don't seem to find them in CVS. Did you use a special branch or is it just not checked in yet?
richard.gronback commented on 2009-05-20
Changed and regenerated in my local workspace. As mentioned above, there are still problems building the DSL Toolkit (see ECLIPSE-277105 for the latest). Once I get a stable build again, I'll check in and rebuild.
I didn't get the impression that this was that urgent.
richard.gronback commented on 2009-05-21
Changes to model are available in the DSL Toolkit M7 build: http://download.eclipse.org/modeling/amalgam/dsltk/downloads/drops/S20090521-0858/index.php
A build model Contribution can contain features and bundles but there is currently no way to specify a product. Since products needs to be contributed to Galileo (see ECLIPSE-276815), I would like to request this as an additional element in the build model.
🆔 ECLIPSE-276968👷 thomas.hallgren📅 2009-05-19