search

eclipse / buildship

The Eclipse Plug-ins for Gradle project.
533 stars 169 forks source link

Sort Project Configurators according to their runsBefore/runsAfter attributes (#1032) #1215

Closed thomasdelhomenie closed 1 year ago

thomasdelhomenie commented 1 year ago

Fixes #1032

Context

When adding a ProjectConfigurator with the extension "org.eclipse.buildship.core.projectconfigurators", the "runsBefore" and "runsAfter" attributes are not considered. No matter the values set on these attributes, the new ProjectConfigurator is always executed the default ones.

This change makes sure that the ProjectConfigurator objects returned by the method org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.from(List) are always sorted according the these attributes.

The related tests have been adapted to test the behavior of the org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.from(List) method.

https://github.com/eclipse/buildship/issues/1032

donat commented 1 year ago

@thomasdelhomenie thank you for the contribution! I'd like to approve and merge your changes, however, you need to sign the Eclipse Contributor Agreement before: https://www.eclipse.org/projects/handbook/#resources-github

thomasdelhomenie commented 1 year ago

@donat done, I signed the ECA.

donat commented 1 year ago

@thomasdelhomenie Thank you for the contribution!

thomasdelhomenie commented 1 year ago

@donat my pleasure :) thanks! Any plan for a new release?

donat commented 1 year ago

No hard deadlines yet, but I want to have a release soon-ish. One thing I really want in the next release is this PR (WIP). In the meanwhile, snapshot releases are produced fairly regularly. I'll make sure there's one with your changes.

thomasdelhomenie commented 1 year ago

ok great, thanks!