eclipse / buildship

The Eclipse Plug-ins for Gradle project.
530 stars 169 forks source link

Add GradleProjectConfigurator to support smart-import #1219

Closed laeubi closed 1 year ago

laeubi commented 1 year ago

Fixes https://github.com/eclipse/buildship/issues/356

Context

Currently gradle projects are not detected when using smart import. This adds the necessary ProjectConfigurator to support importing gradle projects this way.

laeubi commented 1 year ago

Build complain about

Line does not match expected header line of '^ * Copyright (c) \d\d\d\d Gradle Inc.$'. [RegexpHeader]

but I do not have anything to do with Gradle Inc so why should they hold the copyright of my contributed file?

laeubi commented 1 year ago

@donat can you probably take a look at this? This will really improve user experience and preventing false positive detection in m2eclipse.

donat commented 1 year ago

Sorry for the late reply. We'll take a look shortly.

reinsch82 commented 1 year ago

@laeubi Would you mind rebasing your PR and changing the copyright line to

Gradle Inc. and others

This seems to be the recommended way of leaving the Copyright with it's original creators.

Feel free to add specific copyright notices somewhere down in the file, this was done in the past too.

laeubi commented 1 year ago

Done.

reinsch82 commented 1 year ago

@laeubi you'll need to rebase again shortly, we had to change our copyrights too to match the new rule. For some reason the PR would let it through thx for your help

laeubi commented 1 year ago

@reinsch82 I have adjusted the "marker files", also feel free to enhance this as needed afterwards, this is more a first start to make it work, but you as the gradel experts might have some ideas how to further improve that, I'm only a (seldom) gradle user so most of the time :-)

donat commented 1 year ago

Thank you for the contribution, @laeubi!

jabby commented 1 year ago

Thank you @laeubi

laeubi commented 1 year ago

Great to see this integrated, will this be part of the next Eclipse Release (2023-06) or are there usually release in between?

donat commented 1 year ago

We're planning to do a release in the upcoming weeks, so you can expect your changes to appear in Eclipse 2023-06 by default.