search

eclipse / buildship

The Eclipse Plug-ins for Gradle project.
528 stars 167 forks source link

Provide syntax highlighting in the compare editor #684 #1311

Closed oleosterhagen closed 4 weeks ago

oleosterhagen commented 1 month ago

Fixes #684

This enables syntax highlighting for build scripts (Groovy and Kotlin DSL) in these areas:

(1) For build scripts in Kotlin DSL (Generic Editor) also this fix already released with Eclipse 2024-06 is needed: https://github.com/eclipse-platform/eclipse.platform.ui/pull/1880. In older Eclipse versions a NullPointerException will be thrown.

(2) For build scripts in Kotlin DSL (Generic Editor) also this fix already released with Eclipse 2024-06 is needed: https://github.com/eclipse-platform/eclipse.platform.ui/pull/1873. In older Eclipse versions the content type determination will not work and the file is opened without syntax highlighting.

donat commented 4 weeks ago

I've tested and reviewed your changes. LGTM, merging.