search

eclipse / buildship

The Eclipse Plug-ins for Gradle project.
530 stars 170 forks source link

Dark theme support for Gradle syntax highlighting #682

Open vogella opened 6 years ago

vogella commented 6 years ago

The current color for the Gradle syntax highlighting in the dark theme makes the text unreadable.

selection_303

Please fix, if you need help how to do this, please let me know.

vogella commented 6 years ago

Looks like this is only a theme switch issue. After closing and re-opening the editor it looks better.

selection_305

Maybe you can add a preference listener for the color font switch and refresh the editor?

donat commented 6 years ago

That's correct, the editor only inherits the color scheme from the Java editor, but no preference listening is added. The fix sounds relatively easy. @vogella if you can provide a pr, that would be awesome ;)

vogella commented 6 years ago

It is at the moment unlikely that I find time to contribute a fix, my current backlog in platform is already larger than my available time.

Donát Csikós notifications@github.com schrieb am Fr., 6. Apr. 2018, 10:11:

That's correct, the editor only inherits the color scheme from the Java editor, but no preference listening is added. The fix sounds relatively easy. @vogella https://github.com/vogella if you can provide a pr, that would be awesome ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse/buildship/issues/682#issuecomment-379181136, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIihvfqomxXnD_gHotGA47ExOcEAyHQks5tlyMdgaJpZM4TIOw1 .

JacquesLeRoux commented 2 years ago

Hi,

Dark theme now suggest a change (via a button) in the Egradle editor preferences that works well with darkest theme.