search

eclipse / chemclipse

ChemClipse Project
Eclipse Public License 1.0
33 stars 18 forks source link

Use proper identifiers as identifiers #1708

Open Mailaender opened 3 months ago

Mailaender commented 3 months ago

https://github.com/eclipse/chemclipse/issues/1707

eselmeister commented 3 months ago

Keep the identifier as they are, otherwise the ILibraryService to retrieve the reference spectrum would fail again:

private static final String IDENTIFIER = "Scan Maxima Detector UI"; // $NON-NLS-N$
public static final String IDENTIFIER = "Alkanes Identifier"; // $NON-NLS-N$
public static final String IDENTIFIER = "Manual"; // $NON-NLS-N$
String NIST_IDENTIFIER = "NIST (extern)"; // $NON-NLS-N$

Example file saved with Alkanes Identifier:

Screenshot from 2024-03-20 17-03-43

Identifier changed to org.eclipse.chemclipse.chromatogram.xxd.calculator.supplier.amdiscalri leads to a missing "Comparison Scan" reference:

Screenshot from 2024-03-20 17-05-13