eclipse / chemclipse

ChemClipse Project
Eclipse Public License 1.0
39 stars 18 forks source link

IMarkedIons should include a way tp specify the intend of marking (include, exclude) #19

Closed laeubi closed 5 years ago

laeubi commented 5 years ago

org.eclipse.chemclipse.msd.model.core.support.IMarkedIons are per javadoc a "list of ions which should be considered or not in calculation" the javadoc also mentioned a non exiting interface ExcludedIons but this seems to be gone. To allow clarification of this, we should add an enumeration to the interface that can be specified whether include/exclude/intersect/... mode is desired.

eselmeister commented 5 years ago

If changing IMarkedIons, please review all parts in the code where IMarkedIons are used to avoid unexpected behavior.

Am 20.09.19 um 12:39 schrieb Christoph Läubrich:

org.eclipse.chemclipse.msd.model.core.support.IMarkedIons are per javadoc a "list of ions which should be considered or not in calculation" the javadoc also mentioned a non exiting interface ExcludedIons but this seems to be gone. To allow clarification of this, we should add an enumeration to the interface that can be specified whether include/exclude/intersect/... mode is desired.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/eclipse/chemclipse/issues/19?email_source=notifications&email_token=AAFHUT3Q3VPPJVWSBMQUBC3QKSR6RA5CNFSM4IYVRN3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMUUCOA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFHUT5SLYZR66UB5GIDPMLQKSR6RANCNFSM4IYVRN3A.

--

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net