search

eclipse / chemclipse

ChemClipse Project
Eclipse Public License 1.0
37 stars 18 forks source link

SNIP Baseline correction and Savitzky-Golay Filtering for Spectra was removed #423

Closed Mailaender closed 3 years ago

Mailaender commented 3 years ago

https://www.researchgate.net/publication/334029427_Alternative_Software_zur_MALDI-TOF_MS_Auswertung page 29 to 31 shows the past workflow. This seems to be collateral damage of https://github.com/eclipse/chemclipse/issues/362 and should be undone.

eselmeister commented 3 years ago

@Mailaender I had a look at the case. You're right, that was a mistake and shouldn't happen. Thanks for your report. The toolbar menu entries have been moved to the context sensitive pop-up menu. The functionality still exists. For the MALDI editor, the pop-up menu must be extended to display the scan mass spectrum filter and identifier. I'll inspect how to populate the menu.

Mailaender commented 3 years ago

If you want to clear up the menu strip I suggest to start by removing the Controls menu which only has a placeholder in it.

eselmeister commented 3 years ago

@Mailaender You are right, the "Controls" menu item hasn't been used yet. Hence, I'll create a new issue to remove it.

eselmeister commented 3 years ago

Bildschirmfoto von 2020-10-12 21-37-27

Bildschirmfoto von 2020-10-12 21-37-38

eselmeister commented 3 years ago

@Mailaender This was a quick fix. There is much room for improvements. Currently, the system settings are used by default. The progress dialog is not displayed. An interactive settings page is also not displayed. For example, the settings page handling for chromatograms is located here:

org.eclipse.chemclipse.ux.extension.xxd.ui.methods.SettingsPreferencesPage

The settings functionality should be merged. Additionally, the code of the SettingsPreferencesPage needs some refactoring as the code is not well separated and completely stuffed in the createControl(Composite parent) method.

Let's discuss how to proceed.