search

eclipse / chemclipse

ChemClipse Project
Eclipse Public License 1.0
38 stars 18 forks source link

First Derivative Peak Detector - get peak list #85

Closed eselmeister closed 5 years ago

eselmeister commented 5 years ago

When using the first derivative peak detector via the extension point, detected peaks are added to the chromatogram. One might probably use the peak detector to detect peaks but without adding the peaks. A simple solution is to offer a public method in the detector class. The detector can be called directly in such a case.

We should use this experience to decide whether to improve the peak detector extension point or not.

laeubi commented 5 years ago

This is already possible through the generic Processor Framework via the IMeasurementPeakDetectorinterface, the first derivative peak detector already implements this, and this is used for example in NMR to detect peaks there using FIrst Derivative

eselmeister commented 5 years ago

All right, good to know.

Am 18.10.19 um 12:13 schrieb Christoph Läubrich:

This is already possible through the generic Processor Framework via the IMeasurementPeakDetectorinterface, the first derivative peak detector already implements this, and this is used for example in NMR to detect peaks there using FIrst Derivative

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/eclipse/chemclipse/issues/85?email_source=notifications&email_token=AAFHUTZGQOAMIANZ644EFSLQPGD2ZA5CNFSM4JCEUKR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBTXUGI#issuecomment-543652377, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT3PUYMBLX2A7GDN3BTQPGD2ZANCNFSM4JCEUKRQ.

-- 

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net
eselmeister commented 5 years ago

Could you provide a code example here?

Am 18.10.19 um 12:13 schrieb Christoph Läubrich:

This is already possible through the generic Processor Framework via the IMeasurementPeakDetectorinterface, the first derivative peak detector already implements this, and this is used for example in NMR to detect peaks there using FIrst Derivative

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/eclipse/chemclipse/issues/85?email_source=notifications&email_token=AAFHUTZGQOAMIANZ644EFSLQPGD2ZA5CNFSM4JCEUKR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBTXUGI#issuecomment-543652377, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFHUT3PUYMBLX2A7GDN3BTQPGD2ZANCNFSM4JCEUKRQ.

-- 

OpenChrom - the open source alternative for chromatography / mass spectrometry
Dr. Philip Wenig » Founder » philip.wenig@openchrom.net » http://www.openchrom.net
laeubi commented 5 years ago

You can for example take a look here: https://github.com/eclipse/chemclipse/blob/develop/chemclipse/plugins/org.eclipse.chemclipse.ux.extension.xxd.ui/src/org/eclipse/chemclipse/ux/extension/xxd/ui/swt/NMRMeasurementsUI.java#L191 For NMR, the peaks are not embedded inside the measurement, but placed as a measurment-result object when running the Peakdetector.