search

eclipse / dirigible

Eclipse Dirigible™ Project
https://www.dirigible.io
Eclipse Public License 2.0
267 stars 90 forks source link

[IDE] UI settings are not updated which causes glitches and usability bugs #1071

Open StanZGenchev opened 3 years ago

StanZGenchev commented 3 years ago

Describe the bug Currently, the layout and UI settings have no versioning. This results in glitches and usability bugs whenever default settings are updated and features are added in. For example, the 'Workspaces' tab in Workbench should not be closable anymore but since there is no way to force layout settings change, old users who have updated Dirigible are still able to close it. The current workaround is to tell the user to reset the layout manually.

Expected behavior There should be mechanism that detects whenever incompatible settings are introduced on upgrade and either reset the layout or carry out a migration similar to databases.

ThuF commented 3 years ago

Such settings are stored in browser's Local Storage, for example

Proposal: Introduce new environment variable _(e.g. DIRIGIBLE_BRANDING_KEY)_ to the list of branding related environment variables, that will be used as prefix when storing settings in the Local Storage:

DIRIGIBLE_BRANDING_KEY=XXX
ThuF commented 3 years ago

To go one step further the Eclipse Dirigible version could be used in the setting key name (assuming version 5.12.13):

Note: However this could cause unintended behaviour -> reseting all IDE settings when upgrading to a new version.