search

eclipse / eavp

Eclipse advanced visualization project
Eclipse Public License 1.0
9 stars 15 forks source link

DS components are busted #144

Closed jayjaybillings closed 7 years ago

jayjaybillings commented 7 years ago

The EAVP DS components are busted and post the following errors to the console:

!ENTRY org.eclipse.eavp.viz.service.paraview 4 0 2017-02-15 09:26:53.539
!MESSAGE [org.eclipse.eavp.viz.service.paraview.proxy.Factory(77)] doFindMethod: Suitable but non-accessible method found in class org.eclipse.eavp.viz.service.paraview.proxy.ParaViewProxyFactory

!ENTRY org.eclipse.eavp.viz.service.paraview 4 0 2017-02-15 09:26:53.539
!MESSAGE [org.eclipse.eavp.viz.service.paraview.proxy.Factory(77)] findMethod: Suitable but non-accessible method registerProxyBuilder found in class org.eclipse.eavp.viz.service.paraview.proxy.ParaViewProxyFactory, subclass of org.eclipse.eavp.viz.service.paraview.proxy.ParaViewProxyFactory

!ENTRY org.eclipse.eavp.viz.service.paraview 4 0 2017-02-15 09:26:53.540
!MESSAGE [org.eclipse.eavp.viz.service.paraview.proxy.Factory(77)] bind method [registerProxyBuilder] not found; Component will fail

!ENTRY org.eclipse.eavp.viz.service.paraview 4 0 2017-02-15 09:26:53.540
!MESSAGE [org.eclipse.eavp.viz.service.paraview.proxy.Factory(77)] bind method [registerProxyBuilder] not found

!ENTRY org.eclipse.eavp.viz.service.paraview 4 0 2017-02-15 09:26:53.540
!MESSAGE [org.eclipse.eavp.viz.service.paraview.proxy.Factory(77)] bind method [registerProxyBuilder] not found

!ENTRY org.eclipse.eavp.viz.service.paraview 4 0 2017-02-15 09:26:53.540
!MESSAGE [org.eclipse.eavp.viz.service.paraview.proxy.Factory(77)] bind method [registerProxyBuilder] not found

The problem is using services with static setters. It is OK to use a static field, but the updates to bndtools, Apache Felix DS, and the subsequent inclusion of that code into Equinox causes these errors. Fixing this is as simple as removing the static access modifier and replacing any instances of

MyServiceHolder.set(foo);

with

MyServiceHolder holder = new MyServiceHolder();
holder.set(foo);
SmithRWORNL commented 7 years ago

Fixed by commit 905eb11a1af63222ef16ee2c329d9d18d44a0c4b

jayjaybillings commented 7 years ago

That would seem to be a commit about xtext?

Jay Jay Billings Oak Ridge National Laboratory Twitter Handle: @jayjaybillings

From: SmithRWORNL notifications@github.com Sent: Wednesday, February 15, 2017 12:57 PM To: eclipse/eavp Cc: Billings, Jay Jay; Author Subject: Re: [eclipse/eavp] DS components are busted (#144)

Fixed by commit 905eb11https://github.com/eclipse/eavp/commit/905eb11a1af63222ef16ee2c329d9d18d44a0c4b

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/eclipse/eavp/issues/144#issuecomment-280087284, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGFVYYmcdJ5m8acmWjhzL0ekpTtZQ7mTks5rczybgaJpZM4MByX_.

SmithRWORNL commented 7 years ago

Grabbed the wrong commit message there.

Should have been the commit above that referenced this issue, db6a2c3086877a144b5bddd89da85e522792e515.