search

eclipse / eavp

Eclipse advanced visualization project
Eclipse Public License 1.0
9 stars 15 forks source link

There are problems with the january.geometry.model bundle, and the STLGeometryImporter fails tests #79

Closed KasperGam closed 8 years ago

KasperGam commented 8 years ago

The bundle's manifest declares a different name for it's bundle now, breaking the editor bundle's code. It does not have the right name for the new EMF model in the plugin.xml file.

For the STL Xtext stuff, the grammar has flaws when tested outside the bundle (with a generated ecore model). However, fixing it still causes problems and test failures.

The ShapeImpl class in the model's generated code should not instantiate it's lists!!! This is done by lazy instantiation and hard coded instantiation breaks some of Xtext's code.

SmithRWORNL commented 8 years ago

Addressed by merged pull request #80