Setup on the contribution page fails

[opcoach]

I used the setup configuration on this page : https://github.com/eclipse/ecf/blob/master/CONTRIBUTING.md

Drag and drop in the installer and I got this error during install :

[scottslewis]

I need @merks to help with diagnosis on this, as he's the author of the .setup file referenced.

[merks]

The problem is here:

https://github.com/eclipse/ecf/blob/e355fb411958bd12f0c678e5a76476198c8048e8/releng/features/org.eclipse.ecf.xmpp.feature/feature.xml#L48

which was introduced by this commit.

https://github.com/eclipse/ecf/commit/70d98df687a3c61b2e602bacae0774789069532d#diff-fdc3f9d6ab8d3c5235a7bd75c45771e2cfd477cdeef1ed95c318ba8786b800e4R58

I'm not sure which problem that fixed, but now whenever the Orbit version is upgraded, the setup will be broken. Also, you will no longer be following the latest Orbit versions and will generally cause problems contributing to SimRel, e.g., causing duplicates like this one:

Of course it would be best to not include 3rd party libraries in features.

Changing it back to 0.0.0 fixed the problem and generates a new target platform

But there is still a sea of red because JDT no longer support BREE < 1.8.

How best can I help address these types of issues? It's very tedious work to upgrade all the projects:

PDE now has a Modify button to make the upgrade easier, i.e., the settings and the classpath need to change too.

So I can help do this, but given it's a lot of work, so I want to be sure that a PR will be processed before investing that effort.

[scottslewis]

The problem is here:

https://github.com/eclipse/ecf/blob/e355fb411958bd12f0c678e5a76476198c8048e8/releng/features/org.eclipse.ecf.xmpp.feature/feature.xml#L48

which was introduced by this commit.

70d98df#diff-fdc3f9d6ab8d3c5235a7bd75c45771e2cfd477cdeef1ed95c318ba8786b800e4R58

Thanks.

I'm not sure which problem that fixed, but now whenever the Orbit version is upgraded, the setup will be broken. Also, you will no longer be following the latest Orbit versions and will generally cause problems contributing to SimRel, e.g., causing duplicates like this one:

> > Of course it would be best **to not include 3rd party libraries in features.** Yes. As I recall, this is an old feature who's 3rd party library (formerly from Orbit) had a version increment. > > Changing it back to 0.0.0 fixed the problem and generates a new target platform > > > But there is still a sea of red because JDT no longer support BREE < 1.8. > > > How best can I help address these types of issues? It's very tedious work to upgrade all the projects: > Yes. > > PDE now has a Modify button to make the upgrade easier, i.e., the settings and the classpath need to change too. > > So I can help do this, but given it's a lot of work, so I want to be sure that a PR will be processed before investing that effort. At the moment I'm not able to process prs...so no, please do not invest the effort. I appreciate the offer Ed. If/when I can, I may do some removal of older features and bundles from ECF build, so that may help things. But that's not going to be immediate. @opcoach : Sorry, I'm afraid this setup may not work for a while.