search

eclipse / ecf

ECF project repository
7 stars 14 forks source link

Update #40

Closed merks closed 1 year ago

merks commented 1 year ago

I updated your contribution to SimRel to match what is consumed by the platform:

https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/202055

Analyzing duplicates in SimRel I noticed ECF is using quite an old version of ASM compared to the version used by everyone else:

image

I'd update the target platform for you, but I'm not sure which one:

image

A bunch of them seem to be getting changed in the last while:

image

I'm not sure why you explicitly list source bundles when you already have includeSource="true" on the location...

The versions of ASM change quite regularly. Currently it's at 9.5.0. The platform is getting it direct from Maven:

      <location includeDependencyDepth="none" includeDependencyScopes="compile" includeSource="true" label="ASM" missingManifest="error" type="Maven">
          <dependencies>
              <dependency>
                  <groupId>org.ow2.asm</groupId>
                  <artifactId>asm-commons</artifactId>
                  <version>9.5</version>
                  <type>jar</type>
              </dependency>
              <dependency>
                  <groupId>org.ow2.asm</groupId>
                  <artifactId>asm-util</artifactId>
                  <version>9.5</version>
                  <type>jar</type>
              </dependency>
              <dependency>
                  <groupId>org.ow2.asm</groupId>
                  <artifactId>asm</artifactId>
                  <version>9.5</version>
                  <type>jar</type>
              </dependency>
              <dependency>
                  <groupId>org.ow2.asm</groupId>
                  <artifactId>asm-tree</artifactId>
                  <version>9.5</version>
                  <type>jar</type>
              </dependency>
              <dependency>
                  <groupId>org.ow2.asm</groupId>
                  <artifactId>asm-analysis</artifactId>
                  <version>9.5</version>
                  <type>jar</type>
              </dependency>
          </dependencies>
      </location>

And I've been helpful update the version as new versions become available. If you consume directly, you will need to PGP sign the artifacts. You can also get these versions from here where they are already PGP signed:

https://download.eclipse.org/oomph/simrel-maven/

E.g., from here:

https://download.eclipse.org/oomph/simrel-maven/2023-06

How best can I help to get this version updated?

Note that this would be less of a concern if you did not include this bundle in your feature(s). All the bundles actually allow asm up to version 10. Only the feature specifically requires the older version:

image

If we eliminated the include, then I won't be bugging you again until version 10 comes out...

Again, please let me know how best I can help.

scottslewis commented 1 year ago

Hi Ed,

Thanks.   I'll fix/remove asm 9 from feature this coming weekend when I return from time off.

Scott

On 5/24/2023 2:51 AM, Ed Merks wrote:

I updated your contribution to SimRel to match what is consumed by the platform:

https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/202055

Analyzing duplicates in SimRel I noticed ECF is using quite an old version of ASM compared to the version used by everyone else:

image https://user-images.githubusercontent.com/208716/240560569-f5a502ef-16b1-40c5-978a-689c1f753a91.png

I'd update the target platform for you, but I'm not sure which one:

image https://user-images.githubusercontent.com/208716/240561691-8e316066-fec7-47f1-82de-186af4b87e68.png

A bunch of them seem to be getting changed in the last while:

image https://user-images.githubusercontent.com/208716/240561998-5ff24892-5c49-468a-bdd4-0100b0e43789.png

I'm not sure why you explicitly list source bundles when you already have |includeSource="true"| on the location...

The versions of ASM change quite regularly. Currently it's at 9.5.0. The platform is getting it direct from Maven:

|<location includeDependencyDepth="none" includeDependencyScopes="compile" includeSource="true" label="ASM" missingManifest="error" type="Maven">

org.ow2.asm asm-commons 9.5 jar org.ow2.asm asm-util 9.5 jar org.ow2.asm asm 9.5 jar org.ow2.asm asm-tree 9.5 jar org.ow2.asm asm-analysis 9.5 jar | And I've been helpful update the version as new versions become available. If you consume directly, you will need to PGP sign the artifacts. You can also get these versions from here where they are already PGP signed: https://download.eclipse.org/oomph/simrel-maven/ E.g., from here: https://download.eclipse.org/oomph/simrel-maven/2023-06 How best can I help to get this version updated? Note that this would be less of a concern if you did *not* include this bundle in your feature(s). All the bundles actually allow asm up to version 10. Only the feature specifically requires the older version: image If we eliminated the include, then I won't be bugging you again until version 10 comes out... Again, please let me know how best I can help. — Reply to this email directly, view it on GitHub , or unsubscribe . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
scottslewis commented 1 year ago

Hi @merks

It turns out that ECF has some non-eclipse consumers that use the rosgi distribution provider, and this provider (written long ago by other ECF committer) depends upon ASM core bundle. So to make it easier for those consumers, we include the ASM core bundle in the ECF repo.

I've updated the target platform (thanks for the simrel repo links above) and built/deployed ECF version 3.14.39. The repo is here:

http://download.eclipse.org/rt/ecf/3.14.39/site.p2

I tried to update the simrel entry for ECF, but something was wrong with my auth/access/gerrit config. Would you please update the simrel entry ecf.aggrcon? Here's the new content for 3.14.39

<?xml version="1.0" encoding="ASCII"?>

Thanks very much Ed. It's appreciated. Also...if there is up-to-date info for committing changes to simrel these days (via gerrit I assume) please point me at them and I'll update.
merks commented 1 year ago

I've made the following change to SimRel:

https://git.eclipse.org/r/c/simrel/org.eclipse.simrel.build/+/202176

There was a long thread about other people who had problems committing, perhaps you have the same issue:

https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3053#note_1107917

Or perhaps you need a fresh installation with the latest tools which you can create automatically:

https://www.eclipse.org/setups/installer/?url=https://git.eclipse.org/c/oomph/org.eclipse.oomph.git/plain/setups/interim/SimultaneousReleaseTrainConfiguration.setup&show=true

Note that what I've done in a bunch of other projects is either of the following:

Either way, the bundles will then end up in the update site as before but then installing a feature does not lock in a particular version, though there is a version available so that all the bundles of the feature can be installed.

Thanks for addressing the issue!