search

eclipse / ecf

ECF project repository
7 stars 14 forks source link

Register protocol handlers in a lazy fashin #52

Closed laeubi closed 1 year ago

laeubi commented 1 year ago

Currently the activator loads the extension class what might trigger activation of bundles immediatly.

This changes to a more lazy aproach where the extension class is only loaded at frist use of the protocol.

scottslewis commented 1 year ago

Hi Christoph.

To make certain: This change is only about doing things more lazily, right? There isn't some bug or semantic change that this is meant to address?

The reason I ask is that since this code used in Eclipse (p2) I recall something long ago about the p2 startup sequence (which I'm not completely familiar with) potentially requiring (at one point in the past if not now) a greedy startup/setting of the url stream handler service (maybe because equinox sets it as well?). At any rate I would ask that we do a little checking. I will help with this in the coming week.

laeubi commented 1 year ago

To make certain: This change is only about doing things more lazily, right? There isn't some bug or semantic change that this is meant to address?

Correct, at least from my testing :-)

The reason I ask is that since this code used in Eclipse (p2) I recall something long ago about the p2 startup sequence (which I'm not completely familiar with) potentially requiring (at one point in the past if not now) a greedy startup/setting of the url stream handler service (maybe because equinox sets it as well?).

The handler is still eagerly registered, it is just delaying the loading of the implementation class until the first request is made to the handler, this is similar to changes in

At any rate I would ask that we do a little checking. I will help with this in the coming week.

Thanks!

laeubi commented 1 year ago

@scottslewis any idea about the build? I can't really understand what is causing the failure or how to see the full buildlog...

wimjongman commented 1 year ago

Christoph I have authorized you for this specific build. Let me know if this works for you:

image

laeubi commented 1 year ago

It seems the PR just triggers another build so I just found the buildlog now, thanks!

laeubi commented 1 year ago

But now Github seems playing tricks on me if I look here:

https://github.com/laeubi/ecf/commit/96b178bc42228fcc7444ce3a31e5e42110b03443

I see 4 changed files, but this PR only shows 3 changed files....

laeubi commented 1 year ago

I have created a new PR now, sorry for confusion: