search

eclipse / ecf

ECF project repository
7 stars 14 forks source link

Support a cookie store for filetransfer.httpclientjava #55

Closed merks closed 1 year ago

merks commented 1 year ago

Like org.eclipse.ecf.provider.filetransfer.httpclientjava.sharedClient, org.eclipse.ecf.provider.filetransfer.httpclientjava.cookieStore is a system property that can be used to enable/disable the cookie store and like that property, its true by default.

merks commented 1 year ago

@laeubi @scottslewis

Every time the implementation of the filetransfer changes, I end up with yet another hack to try to get cookies to be processed. In this case that hack would involve setting final fields which is not something I can expect to keep working.

So I'd like to just enable cookie processing as already implemented directly by the JDK.

eclipse-ecf-bot commented 1 year ago

Can one of the admins verify this patch?

scottslewis commented 1 year ago

This has been merged and built. Snapshot build 3..14.40 available at https://download.eclipse.org/rt/ecf/snapshot