search

eclipse / ecf

ECF project repository
6 stars 14 forks source link

Fix HttpClientProxyCredentialProvider.getPasswordAuthentication #78

Closed merks closed 9 months ago

merks commented 9 months ago

Ensure that httpclientjava's HttpClientProxyCredentialProvider.getCredentials(AuthScope) is called with a correct AuthScope from getPasswordAuthentication.

Also update some target platform dependencies for the 2022-03 target to use the most recently released versions of client5/core5. Focus particularly on what is required by the httpclient5 feature because that's pulled into p2 and hence almost all installations, e.g., it does not need to include org.apache.commons.logging and should use the latest org.apache.commons.commons-codec rather than org.apache.commons.codec.

https://github.com/eclipse/ecf/issues/76 https://github.com/eclipse/ecf/issues/77

eclipse-ecf-bot commented 9 months ago

Can one of the admins verify this patch?

merks commented 9 months ago

FYI, I also did a test build in EMF's ci instance to produce this repository with signed content:

https://ci.eclipse.org/emf/job/test-ecf/lastSuccessfulBuild/artifact/releng/org.eclipse.ecf.releng.repository/target/repository/

This also lets me verify that with the above build, the Platform will be able to consume only the latest dependencies:

image

scottslewis commented 9 months ago

I have merged this commit and built a new snapshot that includes it here:

https://download.eclipse.org/rt/ecf/snapshot/site.p2/3.14.40.v20231114-1017

scottslewis commented 9 months ago

Hi Ed. Does this comment

https://github.com/eclipse-equinox/p2/issues/381#issuecomment-1812984495

indicate that the fix for this issue doesn't work as desired?

sratz commented 9 months ago

Hi Ed. Does this comment

eclipse-equinox/p2#381 (comment)

indicate that the fix for this issue doesn't work as desired?

Indeed, it's not enough :( See https://github.com/eclipse/ecf/issues/76#issuecomment-1815436819 + https://github.com/eclipse/ecf/issues/76#issuecomment-1815471621