Closed motlin closed 11 months ago
Makes sense, thanks!
On Mon, Sep 11, 2023 at 9:54 AM Craig P. Motlin @.***> wrote:
@.**** commented on this pull request. In checkstyle-configuration.xml https://github.com/eclipse/eclipse-collections/pull/1511#discussion_r1321828569 : @@ -246,8 +246,6 @@ <module name="SimplifyBooleanReturn" /> I looked at the build failure on the dependabot review: #1510 https://github.com/eclipse/eclipse-collections/pull/1510 It says You have 677 Checkstyle violations. and they are all (design) FinalClass: Class KeySet should be declared as final. I don't know if the check was broken and they fixed it, or if they made it more strict, or what. I just disabled the check to move forward. — Reply to this email directly, view it on GitHub https://github.com/eclipse/eclipse-collections/pull/1511#discussion_r1321828569, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLY4XPJHTW7TXH7PBSODP3XZ464XANCNFSM6AAAAAA4TSEANQ . You are receiving this because you commented.Message ID: @.***>
In checkstyle-configuration.xml https://github.com/eclipse/eclipse-collections/pull/1511#discussion_r1321828569 :
@@ -246,8 +246,6 @@
<module name="SimplifyBooleanReturn" />
I looked at the build failure on the dependabot review: #1510 https://github.com/eclipse/eclipse-collections/pull/1510
It says You have 677 Checkstyle violations. and they are all (design) FinalClass: Class KeySet should be declared as final.
I don't know if the check was broken and they fixed it, or if they made it more strict, or what. I just disabled the check to move forward.
— Reply to this email directly, view it on GitHub https://github.com/eclipse/eclipse-collections/pull/1511#discussion_r1321828569, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACLY4XPJHTW7TXH7PBSODP3XZ464XANCNFSM6AAAAAA4TSEANQ . You are receiving this because you commented.Message ID: @.***>
Makes sense, thanks!
On Mon, Sep 11, 2023 at 9:54 AM Craig P. Motlin @.***> wrote: