search

eclipse / eclipse-collections

Eclipse Collections is a collections framework for Java with optimized data structures and a rich, functional and fluent API.
http://www.eclipse.org/collections
2.39k stars 593 forks source link

Fix performance problem in MutableList.subList() and implement similar optimization as ArrayList.subList() #1620

Closed yoa1226 closed 4 weeks ago

motlin commented 1 month ago

This looks great, thanks. I'm wondering why additional tests are marked not applicable.

yoa1226 commented 1 month ago

@motlin hi, motlin, Thank you for your reply. The reason why additional tests are marked not applicable is that some methods in MutableList are not implemented In it's subclass. list below :

  1. UnmodifiableMutableList , MultiReaderFastList and FastListNoIterator don't support listIterator and addAll.
  2. CompositeFastList don't support addAll(int index, Collection<? extends E> c).

So, unit tests about addAll and listIterator should be ignored in above class.

motlin commented 4 weeks ago

Fixed in #1621