Include padding when setting node sizes in top-down layout

eclipse / elk

Eclipse Layout Kernel - Automatic layout for Java applications.

https://www.eclipse.org/elk/

Other

258 stars 86 forks source link

Include padding when setting node sizes in top-down layout #1046

Closed Eddykasp closed 4 months ago

Eddykasp commented 5 months ago

This fixes a problem where the available child area would become negative if the estimated node size was very small because padding was neglected

soerendomroes commented 5 months ago

ERROR:CompactionStrategy cannot be resolved to a type. (file:/home/runner/work/elk/elk/elkjs/build/src/elk/org/eclipse/elk/alg/disco/Disco.melk line : 42 column : 23)

ERROR:The method or field CompactionStrategy is undefined (file:/home/runner/work/elk/elk/elkjs/build/src/elk/org/eclipse/elk/alg/disco/Disco.melk line : 47 column : 19)

This should not occur so suddenly based on your changes. Can you try this locally?