eclipse / elk

Eclipse Layout Kernel - Automatic layout for Java applications.
https://www.eclipse.org/elk/
Other
257 stars 83 forks source link

File filter in test specification not considered #537

Closed uruuru closed 4 years ago

uruuru commented 4 years ago

Setting a filter like so new ModelResourcePath("realworld/ptolemy/flattened/**/").withFilter(new FileExtensionFilter("elkg")) Adds elkt files as well.

I guess the following line is the problem: https://github.com/eclipse/elk/blob/bbea5044afab334b953e96224d7c031e611969fe/test/org.eclipse.elk.alg.test/src/org/eclipse/elk/alg/test/framework/graph/GraphFromFile.java#L88

Presumably this should only be done for resource paths that do not have a filter set, yet.

@le-cds ?

uruuru commented 4 years ago

Fixed by only setting the default file filter if no custom filter has been set by the user.