eclipse-egf-bot
commented
3 years ago ed.merks commented on 2019-09-27
The entire repo is in a bad state with CRLF ending having been committed to the underling remote Git repository; some files even have mixture of the CRLF and LF in the remote repository. E.g.,
deprecated/3.3/features/org.eclipse.egf.portfolio.genchain.ecoretools.feature/build.properties
This makes contribution to your project very difficult. :-(
While I see a diff like this in the IDE:
Eclipse Public License Version 1.0 (available at\n\ http://www.eclipse.org/legal/epl-v10.html)\n\
Eclipse Public License Version 1.0 (available at\n\ http://www.eclipse.org/legal/epl-v20.html)\n\
The review shows the entire file changed because it's converted the file to use LF instead of CRLF.
I'm not sure you want to leave the repo in this poor state.
ed.merks commented on 2019-09-27
Note also that these changes to the feature.properties is a content change and one should also minimally increment each feature's micro version.
ci-bot commented on 2019-10-02
Merged to [master]. Commit: http://git.eclipse.org/c/egf/org.eclipse.emf.egf.git/commit/?id=f3771a40d20a4d6a102b23771fd7a9f81413687f
thomas.guiu commented on 2019-10-02
Thank you for your contribution.
ed.merks commented on 2019-10-12
Thank you for taking action quickly. :-)
I'll provide a Gerrit commit.
🆔 ECLIPSE-551548👷 ed.merks📅 2019-09-27