search

eclipse / gef-classic

Eclipse GEF(tm) Classic code
Eclipse Public License 2.0
25 stars 49 forks source link

Tooltips on GEF palette are broken on Linux/Wayland #568

Closed rhornig closed 1 week ago

rhornig commented 1 week ago

GEF version 3.21

The tooltips on the palette are shown as a top-level window with decoration in the center of the desktop. Note that this happens ONLY on Linux in a Wayland session and only for the palette items.

image

merks commented 1 week ago

It would seem inconceivable that a Window manager should decide that there should be no way to set the location of a shell, but that appears to be the case and is likely the cause of the problem:

https://github.com/eclipse-platform/eclipse.platform.swt/issues/790

rhornig commented 1 week ago

It seems to be a regression in 3.21 because I don't seem to remember this issue with 3.20. Perhaps caused by a side effect of this commit? https://github.com/eclipse/gef-classic/commit/1836f13a4f47a5ea4d4453ac3d44d8a79c537df6

It's also interesting that it affects only the palette entries but not the rest of figures in the editor.

ptziegler commented 1 week ago

Likely a duplicate of https://github.com/eclipse/gef-classic/issues/555. Does this also happen with the current nightly build?

ptziegler commented 1 week ago

The real issue is that on Linux Wayland the tooltip is displayed in the centre of the screen, not over the object, and grabs the focus. This is because the Shell created in PopupHelper has the Display as its parent because of the change in https://github.com/eclipse/gef-classic/commit/843e56c0df42aec34a487b97483a0b6c866fff95

rhornig commented 1 week ago

Likely a duplicate of #555. Does this also happen with the current nightly build?

Indeed this is a duplicate and does not happen on the head version anymore. Thanks for the info.